Fix gcc 5.4 build #65
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix an unused variable warning
Didn't notice the debug config already had it
|
Seems reasonable -- can you leave the |
|
I put back fPIC and also add it to the release file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the CXX switch -std=c++11 in config-linux-gcc.py.
I don't know why I'm the first to hit this, but If I don't specify -std=c++11, I get the same build errors as in this issue:
#7
I'm building from a minimal Ubuntu 16.04 docker file.
I noticed the debug variant already had the c++11 switch at the end, I moved it to the front.
There's an extra -fPIC switch in CXXFLAGS in the debug variant.
Removed it and it's still added to every g++ calls so it's unnecessary.